[Bug 32844] Allow Gabble plugins to provide additional TpChannelManager implementations

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32844

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://cgit.freedesktop.org
                   |                            |/~jonny/telepathy-gabble/lo
                   |                            |g?h=plugin-channel-managers
           Keywords|love                        |patch

--- Comment #3 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-03-02 09:08:12 PST ---
(In reply to comment #2)
> So you wrote this function twice, and one of your two implementations is buggy.
> This is a pretty compelling argument for writing gabble_ptr_array_append() or
> similar.

As I said in the salut bug, having such a helper function wouldn't actually
help in this case (although see bug #34249). I've fixed the wrong one.

> You have a new and interesting definition of empty.

I do. Fixed.

> You didn't add checking for this stuff to tests/twisted/sidecars.py (or I guess
> to a new plugin — this isn't really to do with sidecars).

Done.

All pushed to my branch. CZECH IT OWWWWT.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.