[Bug 35086] wocky_xmpp_error_extract() should fill in @specialized_node for any specialized error.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35086

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-
           Keywords|                            |patch

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2011-03-10 02:42:28 PST ---
I'm not sure about this patch. Why would Wocky ever know about an error
namespace, but not know about one of the errors in that namespace?

Stanza errors have the form:

   <error>
     <defined-condition xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
     <text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>...</text>

     <!-- and optionally -->
     <any-element xmlns='any:namespace'> ... </any-element>
   </error>

With your patch, I think @specialized_node would be set if and only if
any:namespace had previously been registered with Wocky; but surely it would be
more useful to *always* set @specialized_node to the (first) element not in
xmlns='urn:ietf:params:xml:ns:xmpp-stanzas', if one exists?

(Or perhaps I'm misreading the patch. Either way, adding a test case alongside
the existing extract_errors() tests in tests/wocky-stanza-test.c would help
clarify the intent, and verify that it works. :))

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.