[Bug 35086] wocky_xmpp_error_extract() should fill in @specialized_node for any specialized error.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35086

--- Comment #3 from Stef Walter <stefw at collabora.co.uk> 2011-03-10 04:34:57 PST ---
Can there (In reply to comment #2)
> I'm not sure about this patch. Why would Wocky ever know about an error
> namespace, but not know about one of the errors in that namespace?

Because the namespace has an extensible or indeterminate set of errors?

> Stanza errors have the form:
> 
>    <error>
>      <defined-condition xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
>      <text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>...</text>
> 
>      <!-- and optionally -->
>      <any-element xmlns='any:namespace'> ... </any-element>
>    </error>

Can there only be one <any-element>?

> With your patch, I think @specialized_node would be set if and only if
> any:namespace had previously been registered with Wocky; but surely it would be
> more useful to *always* set @specialized_node to the (first) element not in
> xmlns='urn:ietf:params:xml:ns:xmpp-stanzas', if one exists?

I can do this. But if more than one <any-element> type specialized node can be
present, this raises the obvious question of whether @specialized should always
match @specialized_node or not.

> (Or perhaps I'm misreading the patch. Either way, adding a test case alongside
> the existing extract_errors() tests in tests/wocky-stanza-test.c would help
> clarify the intent, and verify that it works. :))

Okay, will do.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.