[Bug 35331] Support ContactBlocking in TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35331

Danielle Madeley <danielle.madeley at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danielle.madeley at collabora.
                   |                            |co.uk

--- Comment #2 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2011-05-02 23:38:18 PDT ---
Pretty good. Minor points follow...

+            /* Sometimes I think we should either make our method names less
+             * verbose, or relax our 80-column limit.
+             */

Probably not useful to include?

-      g_return_if_fail (iface->block_contacts_async != NULL);
+      g_return_if_fail (iface->block_contacts_async != NULL ||
+          iface->block_contacts_with_abuse_async != NULL);

XOR perhaps?

+  if (iface->block_contacts_with_abuse_async != NULL)
+    g_value_set_uint (value,
TP_CONTACT_BLOCKING_CAPABILITY_CAN_REPORT_ABUSIVE);
+  else
+    g_value_set_uint (value, 0);
+}

Not expandable. Think this would be better:

if (...)
  flags |= CAN_REPORT_ABUSIVE;

g_value_set_uint (value, flags);

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.