[Bug 33911] Remove Loudmouth wrapper

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33911

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-05-03 01:12:32 PDT ---
(Why can't I copy paste spaces today I wonder?

+  if (vcard_error->domain == WOCKY_XMPP_ERROR)
+    if (vcard_error->code == WOCKY_XMPP_ERROR_BAD_REQUEST ||
+        vcard_error->code == WOCKY_XMPP_ERROR_NOT_ACCEPTABLE)
       tp_error.code = TP_ERROR_INVALID_ARGUMENT;

Can't say I approve of this, but yeah it's not new code.

  DEBUG ("fetching location failed: %s", wocky_error->message);
+ /* FUUCK */
  gabble_set_tp_error_from_wocky (wocky_error, &tp_error);

Hm?

- GError *error = gabble_message_get_xmpp_error (reply);
+ GError *error = NULL;
+
+ /* FIXME: did anything depend on getting errors outside core? */
+ wocky_stanza_extract_errors (reply, NULL, &error, NULL, NULL);

This is not a regression though, is it?

- /* FIXME: add a helper in error.c to extract the type, error, and message
- * from an XMPP stanza.
- */

Woo!

Basically fine though.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.