[Bug 33271] Implement ChannelDispatcher.DelegateChannels() and PresentChannel()

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33271

--- Comment #6 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-05-11 03:07:33 PDT ---
+ /* All the channels should belong to the same account, so we just need
+ * to get the connection for the first one. */

o rly? The spec says nothing about this?

+ g_object_get (self->priv->master, "account-manager", &am, NULL);
+ g_assert (am != NULL);
+
+ account = mcd_account_manager_lookup_account_by_path (am, chan_account);
+ g_assert (account != NULL);

I'm not sure about asserting on failures. With non-fatal assertions MC will
continue to run but PresentChannels won't return? I realise it's only going to
fail in a very odd case, but still.

Otherwise looks fine.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.