[Bug 34610] Add API for DelegateChannels() and PresentChannel()

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed May 11 12:21:22 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=34610

--- Comment #2 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-05-11 03:21:22 PDT ---
+ chans = g_ptr_array_sized_new (g_list_length (channels));
+ g_ptr_array_set_free_func (chans, g_free);
+
+ for (l = channels; l != NULL; l = g_list_next (l))
...

makes me a little unhappy but I'm not sure what to do.

Why don't you make _delegate_channels_async take a GPtrArray instead of a
GList?

I'm not sure what your PresentChannel test actually tests, but whatever.

Looks good otherwise.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list