[Bug 37106] New: Unnecessarily hides GInterface vtables

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed May 11 12:37:44 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=37106

           Summary: Unnecessarily hides GInterface vtables
           Product: Telepathy
           Version: 5.7
          Platform: Other
               URL: http://cgit.collabora.co.uk/git/user/smcv/telepathy-mi
                    ssion-control-smcv.git/log/?h=expose-ifaces
        OS/Version: All
            Status: ASSIGNED
          Keywords: patch
          Severity: normal
          Priority: medium
         Component: mission-control
        AssignedTo: simon.mcvittie at collabora.co.uk
        ReportedBy: simon.mcvittie at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org
                CC: will.thompson at collabora.co.uk
        Depends on: 32914
            Blocks: 27363


+++ This bug was initially created as a clone of Bug #32914 +++

wjt wrote:
> But I can't chain up, because McpAccountStorageIface is hidden, and the vtable > is filled in using _implement_foo functions. This seems completely pointless to > me. The main rationale for this pattern in tp-glib's generated interfaces is to > avoid reorderings in the spec affecting ABI

It is indeed pointless: GObject upstream don't consider appending to a
GInterface vtable struct (the ones that start with a GTypeInterface) to be an
incompatible change.

wjt's branch fixes AccountStorage, a recently-merged branch fixes
DispatchOperationPolicy, and the branch in the URL field here fixes the
remaining implemented-by-plugins classes so far, namely RequestPolicy and
DBusAcl. It also improves some documentation.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list