[Bug 32914] Hiding the McpAccountStorageIface struct prevents subclasses chaining up.

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed May 11 12:32:33 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=32914

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review+
           Keywords|love                        |patch
         AssignedTo|telepathy-bugs at lists.freede |will.thompson at collabora.co.
                   |sktop.org                   |uk

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-05-11 03:32:32 PDT ---
A belated r+ for your branch, except that commit 3/3 should be amended to say
McpAccountStorageIface, not McpAccountManagerIface.

(For the record: it's correct that McpAccountManagerIface is in
implementation.h, and likewise for DispatchOperation and Request, because
they're meant to only ever be implemented by MC itself.)

I have a branch to do the same with the remaining interfaces, and also improve
documentation; I'll clone a bug.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list