[Bug 34610] Add API for DelegateChannels() and PresentChannel()

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34610

--- Comment #3 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-05-11 04:13:33 PDT ---
(In reply to comment #2)
> + chans = g_ptr_array_sized_new (g_list_length (channels));
> + g_ptr_array_set_free_func (chans, g_free);
> +
> + for (l = channels; l != NULL; l = g_list_next (l))
> ...
> 
> makes me a little unhappy but I'm not sure what to do.
> 
> Why don't you make _delegate_channels_async take a GPtrArray instead of a
> GList?

Because we usually use GList in high level API (see for example
TpBaseClientClassObserveChannelsImpl and friends).

But I'm ready to be convinced otherwise.

> I'm not sure what your PresentChannel test actually tests, but whatever.

Not much, but at least his code is run in a test (and it did help me to find a
bug: I was passing the wrong source_tag when checking in _finish).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.