[Bug 33271] Implement ChannelDispatcher.DelegateChannels() and PresentChannel()

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33271

--- Comment #7 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-05-11 04:28:56 PDT ---
(In reply to comment #6)
> + /* All the channels should belong to the same account, so we just need
> + * to get the connection for the first one. */
> 
> o rly? The spec says nothing about this?

I think that make sense, don't you? I'll update the spec if you agree that's a
sane requierement.

> + g_object_get (self->priv->master, "account-manager", &am, NULL);
> + g_assert (am != NULL);

There are a loads of exactly the same assertion in the code.

> + account = mcd_account_manager_lookup_account_by_path (am, chan_account);
> + g_assert (account != NULL);
> 
> I'm not sure about asserting on failures. With non-fatal assertions MC will
> continue to run but PresentChannels won't return? I realise it's only going to
> fail in a very odd case, but still.

I changed to g_return_if_fail() for the other assertions.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.