[Bug 37112] Doesn't wait to get contact alias before adding event

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed May 11 21:07:05 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=37112

Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-
           Keywords|patch                       |

--- Comment #2 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-05-11 12:07:04 PDT ---
> text-channel: fix typo

There was other case around where the same typo was made. Also the GError where
not freed. I've allowed myself rewriting it correctly and merged.

> all: fix -Wunused-but-set-variable warnings
> log-store-xml: fix -Wuninitialized warnings

All good, merged. I did that since I realized that some change on the 32bit
builder would cause those to come out.

> text-channel: use the TpContact we've already prepared for received messages

This one is not a proper fix. Each message may contains sender-nickname header,
which must be used as alias. If not present, probably take one of our prepared
account, and if we don't have one, then maybe we should call _prepare_async()
to finish preparation ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list