[Bug 37112] Doesn't wait to get contact alias before adding event

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37112

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-                     |

--- Comment #3 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-05-12 01:25:40 PDT ---
(In reply to comment #2)
> There was other case around where the same typo was made. Also the GError where
> not freed. I've allowed myself rewriting it correctly and merged.
[snip]
> All good, merged. I did that since I realized that some change on the 32bit
> builder would cause those to come out.

Thanks, but you know I have commit access and could have done this myself like
a big boy?

> This one is not a proper fix. Each message may contains sender-nickname header,
> which must be used as alias. If not present, probably take one of our prepared
> account, and if we don't have one, then maybe we should call _prepare_async()
> to finish preparation ?

True that, I forgot about sender-nickname (even though I was the one who added
it!) Butterfly is the only CM which makes use of it. I think we should just
fall back to using the priv->remote contact if sender-nickname is not present.

I've no idea what you mean about "take one of our prepared account" and "call
_prepare_async() to finish preparation".

I updated my branch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.