[Bug 37112] Doesn't wait to get contact alias before adding event

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37112

--- Comment #4 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-05-12 07:46:24 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> Thanks, but you know I have commit access and could have done this myself like
> a big boy?

Don't take offense, I do that only when build is broken on the buildbot.

> 
> > This one is not a proper fix. Each message may contains sender-nickname header,
> > which must be used as alias. If not present, probably take one of our prepared
> > account, and if we don't have one, then maybe we should call _prepare_async()
> > to finish preparation ?
> 
> True that, I forgot about sender-nickname (even though I was the one who added
> it!) Butterfly is the only CM which makes use of it. I think we should just
> fall back to using the priv->remote contact if sender-nickname is not present.
> 
> I've no idea what you mean about "take one of our prepared account" and "call
> _prepare_async() to finish preparation".

"take one of our prepared account" == priv->remote

"call _prepare_async() ..."

What I mean is that at last resort, we should do the async prepare call on the
TpContact sender object, even for rooms. Otherwise there will still be cases
where it's not the alias that is being logged.

> 
> I updated my branch.

Will have a look.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.