[Bug 37034] Telepathy-Qt4 doesn't set the URI property for file transfers.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37034

--- Comment #9 from Olli Salli <ollisal at gmail.com> 2011-05-29 10:36:35 PDT ---
Oh and please add an unit test, which checks the operation of the path
constructor both when passed an existent file and a nonexistent one as this is
non-trivial. (First case: valid one, with the size of some small actual file
you added. Second case: invalid.)

This test can be one case of the Account test which tests a lot of other
Account channel requesting things (TestAccountChannelDispatcher IIRC), you
don't have to create a separate test application.

98        parent->connect(fileTransferInterface,
99                SIGNAL(URIDefined(QString)),
100                SLOT(onUriDefined(QString)));

Umm, why don't I see this slot anywhere?

Remember that this can only change for Incoming FTs, so you only need to
connect to it in IFTC, not here at all. I suppose you need to connect the IFTC
signal to onUriChanged, though, to update the URI property returned by the
accessor? You might want to do that in the subclass constructor (because the
signal exists only for that subclass).

153   warning() << "FileTransferChannel::FeatureCore must be ready before "
154      "calling acceptFile";

Yet the user has called setUri, not acceptFile. Otherwise a warning is a good
idea in this case.

322     * is requested. For incoming file transfers, this property may be set
by the
323     * channel handler before calling AcceptFile to inform observers where
the
324     * incoming file will be saved.

Please mention the IFTC signal which will be emitted when this happens.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.