[Bug 37034] Telepathy-Qt4 doesn't set the URI property for file transfers.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37034

--- Comment #10 from Olli Salli <ollisal at gmail.com> 2011-05-29 10:48:20 PDT ---
In the docs, obviously the things pertaining to the actual code/API changes
required need changing, other than that they look good, except for a few
nitpicks:

199    /**
200     * Create a FileTransferChannelCreationProperties used to initiate the
201     * properties for a file transfer channel.
202     */

/** Copy constructor. */ please, as this is nothing more.

> ... used to initiate the
> 133	 * properties for a file transfer channel.
> ... will be used when requesting a new file transfer
> 231	 * channel
> will be used when requesting a new file transfers
> 277	 * channel.

You don't need to repeat the class's purpose in every method's description.
Describe these kinds of things in the class description, and only describe what
a given method does in the class context in the method ones (e.g. "Sets a
content hash for the request").

Also in the accessors, please refer to concepts ("content hash") rather than
D-Bus properties ("the ContentHash and ContentHashType properties").

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.