[Bug 40734] Implement Channel.Interface.Subject

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=40734

--- Comment #6 from Will Thompson <will.thompson at collabora.co.uk> 2011-10-28 04:18:44 PDT ---
Comment on attachment 52835
  --> https://bugs.freedesktop.org/attachment.cgi?id=52835
MUCChannel: Queue SetSubject calls and return asynchronously

Review of attachment 52835:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=40734&attachment=52835)
-----------------------------------------------------------------

AFAICT: the server returning an error isn't handled, and nor is the case where
the server has truncated the topic. So in either of these cases, a SetSubject()
call will never return, and the queued follow-up commands will never return
either.

In Gabble, I made SetSubject() return:

• successfully when *any* subject update is received (the protocol doesn't
really allow the client to match up the request and the response);
• an error when the server responds with an error (which is a little fiddly to
match up, but possible).

Queueing up successive requests is nice to have, but if the channel closes
without getting a reply from the server, those method calls will never return
either.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.