[Bug 40734] Implement Channel.Interface.Subject

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=40734

--- Comment #7 from Debarshi Ray <debarshi.ray at gmail.com> 2011-10-28 05:15:01 PDT ---
(In reply to comment #6)
> Comment on attachment 52835 [details] [review]
> MUCChannel: Queue SetSubject calls and return asynchronously
> 
> Review of attachment 52835 [details] [review]:

Thanks for the review.

> -----------------------------------------------------------------
> 
> AFAICT: the server returning an error isn't handled, and nor is the case where
> the server has truncated the topic. So in either of these cases, a SetSubject()
> call will never return, and the queued follow-up commands will never return
> either.
> 
> In Gabble, I made SetSubject() return:
> 
> • successfully when *any* subject update is received (the protocol doesn't
> really allow the client to match up the request and the response);
> • an error when the server responds with an error (which is a little fiddly to
> match up, but possible).

Right. It was a quick hack. I will address these issues.

> Queueing up successive requests is nice to have, but if the channel closes
> without getting a reply from the server, those method calls will never return
> either.

Right. I am wondering if the queueing implementation in idle-contact-info.c
will have similar problems or not. We free up the queue when the IdleConnection
is finalized.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.