[Bug 40537] Make dependency on libsoup optional
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Thu Sep 1 10:40:01 CEST 2011
https://bugs.freedesktop.org/show_bug.cgi?id=40537
--- Comment #1 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2011-09-01 01:40:00 PDT ---
#ifdef ENABLE_GOOGLE_RELAY
-
tp_clear_object (&self->soup);
+#endif
Unrequired ifdef. self->soup == NULL.
It would be nice to squash these commits.
+static RelaySessionData *
+relay_session_data_new (guint requests_to_do,
+ GabbleJingleFactoryRelaySessionCb callback,
+ gpointer user_data)
+static void
+translate_relay_info (GPtrArray *relays,
+ const gchar *relay_ip,
+ const gchar *username,
+ const gchar *password,
+ const gchar *static_type,
+ const gchar *port_string,
+ guint component)
+static void
+on_http_response (SoupSession *soup,
+ SoupMessage *msg,
+ gpointer user_data)
+void
+gabble_google_relay_resolver_resolve (GabbleGoogleRelayResolver *self,
+ guint components,
+ const gchar *server,
+ guint16 port,
+ const gchar *token,
+ GabbleJingleFactoryRelaySessionCb
callback,
+ gpointer user_data)
Not in Telepathy style.
As mentioned, it would be nice to make this a GIO-style function, but I don't
think that's a blocker.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the telepathy-bugs
mailing list