[Bug 40537] Make dependency on libsoup optional

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=40537

--- Comment #2 from Mikhail Zabaluev <mikhail.zabaluev at nokia.com> 2011-09-01 02:00:45 PDT ---
(In reply to comment #1)
>  #ifdef ENABLE_GOOGLE_RELAY
> -
>    tp_clear_object (&self->soup);
> +#endif
> 
> Unrequired ifdef. self->soup == NULL.

soup is not declared in the no-relay case.
I don't think shifting the delta to the structure declaration by defining a
dummy GObject *soup member would improve the code much.

> It would be nice to squash these commits.

Done (please force-pull your local branches if any).

> +static RelaySessionData *
> +relay_session_data_new (guint requests_to_do,
> +                        GabbleJingleFactoryRelaySessionCb callback,
> +                        gpointer user_data)
> 
> +static void
> +translate_relay_info (GPtrArray *relays,
> +                      const gchar *relay_ip,
> +                      const gchar *username,
> +                      const gchar *password,
> +                      const gchar *static_type,
> +                      const gchar *port_string,
> +                      guint component)
> 
> +static void
> +on_http_response (SoupSession *soup,
> +                  SoupMessage *msg,
> +                  gpointer user_data)
> 
> Not in Telepathy style.

I copied most of these from older code :) OK, indented properly now.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.