[Bug 40933] Too many MembersChanged(Detailed) signals when connecting

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Sep 16 13:09:52 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=40933

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-09-16 04:09:51 PDT ---
> + tp_group_mixin_change_members (sub_chan, "", sub, NULL, NULL, NULL, 100,
> + TP_CHANNEL_GROUP_CHANGE_REASON_NONE);

s/100/0/ (the actor)

> + if (interface == TP_IFACE_QUARK_CHANNEL_INTERFACE_GROUP &&
> + msg_type == DBUS_MESSAGE_TYPE_SIGNAL &&
> + g_strcmp0 (member, "MembersChanged") == 0)

dbus_message_is_signal() is ideal for low-level filters like this

Other than that, looks good to me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list