[Bug 40933] Too many MembersChanged(Detailed) signals when connecting

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=40933

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2011-09-16 04:15:41 PDT ---
+  tp_group_mixin_change_members (sub_chan, "", sub, NULL, NULL, NULL, 100,

Actor 100? :O

The rest of this is just nit-picking

+  closure = g_slice_new0 (MembersChangedClosure);

You don't need to slice-allocate the struct, you could just stick it on the
stack. I don't really care though.

+      g_assert (lookup_contact (self, members[i]) == NULL);

g_assert_cmpstr for future reference. :)

+  /* Now put it online and wait for contact list state move to success */

“wait for the contact list state to move”

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.