[Bug 54033] Ignorelist for logger

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54033

--- Comment #3 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2012-08-27 19:46:17 UTC ---
Comment on attachment 66089
  --> https://bugs.freedesktop.org/attachment.cgi?id=66089
Proposed patch

Review of attachment 66089:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=54033&attachment=66089)
-----------------------------------------------------------------

Why do you convert the string arrays into GSList ? Also, you could enable
regex, this would make your filter more flexible.

::: telepathy-logger/conf.c
@@ +261,5 @@
> +_tpl_conf_set_accounts_ignorelist (TplConf *self,
> +    GSList *newlist)
> +{
> +    GSList *iter;
> +    gint ii, len;

Any reason for ii, why not just i ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.