[Bug 54033] Ignorelist for logger

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54033

--- Comment #4 from Dan Vrátil <dvratil at redhat.com> 2012-08-27 21:24:04 UTC ---
(In reply to comment #2)
> I'll do proper review next week, meanwhile take note that you'll have to
> provide unit test for your new feature. 

I'll provide the unit tests during the week (must learn how to do it first :)

> About that feature, is there any use of
> it that you would like ? Is there any proposal for integration into Empathy ?

We would like to have it in KDE Telepathy

(In reply to comment #3)
> Why do you convert the string arrays into GSList ? 

No particular reason, I just think it's more programmer-friendly. But now I
realize the TplConf API is not public so it makes no sense really....Which
rises a question in my mind - how will users change the values - is direct
changing of the GSettings property OK?

> Also, you could enable regex, this would make your filter more flexible.

OK.

> 
> ::: telepathy-logger/conf.c
> @@ +261,5 @@
> > +_tpl_conf_set_accounts_ignorelist (TplConf *self,
> > +    GSList *newlist)
> > +{
> > +    GSList *iter;
> > +    gint ii, len;
> 
> Any reason for ii, why not just i ?

No, just a habit :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.