[Bug 45514] New: completes GAsyncResults in an insufficiently idle way

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45514

             Bug #: 45514
           Summary: completes GAsyncResults in an insufficiently idle way
    Classification: Unclassified
           Product: Telepathy
           Version: git master
          Platform: Other
               URL: http://cgit.freedesktop.org/~smcv/telepathy-glib/commi
                    t?h=insufficiently-idle
        OS/Version: All
            Status: ASSIGNED
          Severity: normal
          Priority: medium
         Component: tp-glib
        AssignedTo: simon.mcvittie at collabora.co.uk
        ReportedBy: simon.mcvittie at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


Created attachment 56466
  --> https://bugs.freedesktop.org/attachment.cgi?id=56466
Complete results of TpProxy D-Bus calls in an idle

GAsyncResult guarantees to call your callback from the main loop.
For historical reasons (basically "5 years ago I didn't know any
better"), TpProxy does not: if the interface is missing or the proxy
has been invalidated, the callback is called re-entrantly. I'm going
to fix that in Telepathy 1.0, but for now, let's give GAsyncResult
the correct semantics.

(This patch is for master; I'm not sure whether the safer thing for 0.14 would
be to sprinkle in_idle throughout, or leave it as it is.)

Unfortunately, the patch fails tests, because TpAccount makes broken
assumptions about the lifetimes of data and async results. Shaving this
particular yak is a job for tomorrow-man.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.