[Bug 45514] completes GAsyncResults in an insufficiently idle way

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45514

--- Comment #1 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-02-01 12:37:55 PST ---
(In reply to comment #0)
> Created attachment 56466 [details] [review]
> Complete results of TpProxy D-Bus calls in an idle

In general, this patch makes me very unhappy indeed. Completing an async result
in an idle when it's always necessary makes debugging a pain.

But I agree that it should be there.

Your patch looks fine but I didn't audit any of the cases to see if it was
actually necessary.

> (This patch is for master; I'm not sure whether the safer thing for 0.14 would
> be to sprinkle in_idle throughout, or leave it as it is.)

I think leave it without.

> Unfortunately, the patch fails tests, because TpAccount makes broken
> assumptions about the lifetimes of data and async results. Shaving this
> particular yak is a job for tomorrow-man.

Okay I only just noticed there isn't a patch keyword here and yet I still
reviewed it. Oh well.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.