[Bug 46513] Make Jingle code less Telepathic

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46513

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-02-29 04:53:28 PST ---
> +static void
> +gabble_jingle_info_dispose (GObject *object)
> +{
> + GabbleJingleInfo *self = GABBLE_JINGLE_INFO (object);
> + GabbleJingleInfoPrivate *priv = self->priv;
> + GObjectClass *parent_class = gabble_jingle_info_parent_class;
> +
> + if (parent_class->dispose != NULL)
> + parent_class->dispose (object);

Surely dispose should chain up at the end, not the beginning? I see dispose and
finalize as progressively breaking the functionality of the object's classes,
most-derived first.

jingle_info_reply_cb looked crashy, but you fixed that in the next commit.

Everything else up to 39b90872eb "JingleContent: don't store a
GabbleConnection" looks good except as noted already.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.