[Bug 46513] Make Jingle code less Telepathic

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Feb 29 14:14:54 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=46513

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-02-29 05:14:54 PST ---
> + /* Only emitted for new incoming sessions, mainly for legacy reasons */
> + signals[NEW_SESSION] = g_signal_new ("new-session",

Can't the JingleMint's new signal be "incoming-session" or something?

In da9f352766e "Represent Jingle relays by a struct, not an aa{sv}":

> + GPtrArray *tp_relays = gabble_build_tp_relay_info (relays);
> + tp_base_media_call_stream_set_relay_info (stream, tp_relays);

Nitpicking: I'd prefer a blank line between initialized locals and other code.

All reviewed now, looks good apart from the things already noted.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list