[Bug 46513] Make Jingle code less Telepathic

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46513

--- Comment #7 from Will Thompson <will.thompson at collabora.co.uk> 2012-02-29 05:23:41 PST ---
(In reply to comment #5)
> > + /* Only emitted for new incoming sessions, mainly for legacy reasons */
> > + signals[NEW_SESSION] = g_signal_new ("new-session",
> 
> Can't the JingleMint's new signal be "incoming-session" or something?

Good idea. Renamed.

> In da9f352766e "Represent Jingle relays by a struct, not an aa{sv}":
> 
> > + GPtrArray *tp_relays = gabble_build_tp_relay_info (relays);
> > + tp_base_media_call_stream_set_relay_info (stream, tp_relays);
> 
> Nitpicking: I'd prefer a blank line between initialized locals and other code.

Fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.