[Bug 46513] Make Jingle code less Telepathic

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46513

--- Comment #6 from Will Thompson <will.thompson at collabora.co.uk> 2012-02-29 05:17:29 PST ---
(In reply to comment #2)
> > @@ -2374,14 +2361,14 @@ session_terminated_cb (GabbleJingleSession *session,
> >   TpGroupMixin *mixin = TP_GROUP_MIXIN (channel);
> >   guint terminator;
> >   JingleState state;
> > - TpHandle peer;
> > + TpHandle peer = gabble_jingle_session_get_peer_handle (priv->session);
> >   TpIntSet *set;
> >
> >   DEBUG ("called");
> >
> > + peer = gabble_jingle_session_get_peer_handle (priv->session);
> 
> Duplicate call to gabble_jingle_session_get_peer_handle() (in "MediaChannel:
> use gabble_jingle_session_get_peer_handle()", d884caf42e3)

This local gets removed entirely in a later patch, because the MediaChannel
tracks its own peer.

> Everything else up to and including that commit looks good. There might be a
> million patches but at least they're easy to review :-)

I try!

(In reply to comment #3)
> "Send session-{initiate,accept} IQs using porter directly.", 72ea73343252: I
> think you're leaking sess in the callbacks, except in the early-return cases
> where the state has become inappropriate?

Aye. Patch fixing this pushed.

(In reply to comment #4)
> > +static void
> > +gabble_jingle_info_dispose (GObject *object)
> > +{
> > + GabbleJingleInfo *self = GABBLE_JINGLE_INFO (object);
> > + GabbleJingleInfoPrivate *priv = self->priv;
> > + GObjectClass *parent_class = gabble_jingle_info_parent_class;
> > +
> > + if (parent_class->dispose != NULL)
> > + parent_class->dispose (object);
> 
> Surely dispose should chain up at the end, not the beginning? I see dispose and
> finalize as progressively breaking the functionality of the object's classes,
> most-derived first.

Yup. I even called someone out on this the other day. Fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.