[Bug 44331] Gabble plugin API symbols should be factored out to a separate library

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44331

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.freedesktop.or |
                   |g/show_bug.cgi?id=44256     |

--- Comment #18 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-01-09 01:53:14 PST ---
There's more wrong with this patch:

> Change the pluing API to create_sidecar_async and create_sidecar_finish

Perfect?!

You've only updated the test plugin; surely you also need to update the
gateways and console plugins too?

Why are you returning the GAsyncResult in the create_sidecar_async function?
That's really weird.

You should store the GAsyncResult in the plugin's private struct so
create_sidecar_async isn't called twice on the plugin.

-    GabblePluginCreateSidecarImpl create_sidecar;
+     GabblePluginCreateSidecarFinishImpl create_sidecar_finish;

Wrong indentation.

   g_object_unref (result);
+  return g_object_ref (sidecar);

What is this I don't even? Store the GAsyncResult in the private struct of the
plugin, complete it (in an idle if necessary to make sure it re-enters the
mainloop) and unref & clear it straight afterwards. Returning a new ref to the
sidecar is correct, though.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.