[Bug 43828] avoid downloading the roster at every connection

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43828

--- Comment #3 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-01-09 04:30:23 UTC ---
+ { "download-at-connection",

This seems a confusing connection parameter name.
download-contact-list-at-connection is better but is longer than the world. I
guess we can use roster here though as it's gabble.
"download-roster-on-connection" might be better?

Hey wait, isn't the D-Bus property meant to be a connection manager parameter
like DecloakAutomatically?

+ DEBUG ("don't request the roster");

Why not? Say so.

Is there any way we can make gabble_roster_download_async and the changed code
in connection_status_changed_cb share the same code perchance? Perhaps you
could even just make connection_status_changed_cb call
tp_base_contact_list_download_async directly?

I get a little upset seeing new code using conn_util_send_iq_async and not the
WockyPorter methods, but oh well, up to you if you want to fix that.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.