[Bug 44649] Gabble plugin API symbols should be factored out to a separate library

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44649

--- Comment #16 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-01-25 11:03:14 PST ---
I am reviewing the diff between the two patches:

- * Copyright © 2009 Collabora Ltd.
- * Copyright © 2009 Nokia Corporation
+ * Copyright © 2012 Collabora Ltd.

- * Copyright © 2009 Collabora Ltd.
- * Copyright © 2009 Nokia Corporation
+ * Copyright © 2012 Collabora Ltd.

Are these really correct?

+typedef GabblePluginConnectionIface GabblePluginConnectionInterface;

Just rename the interface to …Interface instead of having a typedef around.

(In reply to comment #13)
> +gchar *
> +_gabble_plugin_connection_get_full_jid (GabblePluginConnection *plugin_conn)
> 
> Should be static, no? Same with most of the other functions that are set in
> GabblePluginConnectionIface the struct as they're not used anywhere else in
> gabble?

Is this not the case? You don't seem to have changed anything and you didn't
reply?

> There's also some random whitespace added here and there out of context. You
> should review your own patch before submitting it here.

It would be nice if this was fixed but it's no blocker.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.