[Bug 44649] Gabble plugin API symbols should be factored out to a separate library

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44649

--- Comment #17 from Siraj Razick <siraj.razick at collabora.co.uk> 2012-01-25 11:33:40 PST ---
(In reply to comment #16)
> I am reviewing the diff between the two patches:
> 
> - * Copyright © 2009 Collabora Ltd.
> - * Copyright © 2009 Nokia Corporation
> + * Copyright © 2012 Collabora Ltd.
> 
> - * Copyright © 2009 Collabora Ltd.
> - * Copyright © 2009 Nokia Corporation
> + * Copyright © 2012 Collabora Ltd.
> 
> Are these really correct?

plugin-connection.h/c created in 2012 by collabora so int he final patch it's
2012, and
in connection.h was merged back into one .. so it's 2005-2012 .. 

> 
> +typedef GabblePluginConnectionIface GabblePluginConnectionInterface;
> 
> Just rename the interface to …Interface instead of having a typedef around.
> 
> (In reply to comment #13)
> > +gchar *
> > +_gabble_plugin_connection_get_full_jid (GabblePluginConnection *plugin_conn)
> > 
> > Should be static, no? Same with most of the other functions that are set in
> > GabblePluginConnectionIface the struct as they're not used anywhere else in
> > gabble?
> 
> Is this not the case? You don't seem to have changed anything and you didn't
> reply?
I just missed it sorry.. I don't have a reason not to make it static.

> 
> > There's also some random whitespace added here and there out of context. You
> > should review your own patch before submitting it here.
> 
> It would be nice if this was fixed but it's no blocker.

I'll fix them :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.