[Bug 49372] deprecate tp_account/connection/channel_new

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49372

--- Comment #15 from Xavier Claessens <xclaesse at gmail.com> 2012-07-03 04:30:56 PDT ---
(In reply to comment #12)
> Comment on attachment 61957 [details] [review]
> Examples: stop using tp_account/connection/channel_new()
> 
> Review of attachment 61957 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: examples/client/extended-client.c
> @@ +211,5 @@
> >  
> >    if (die_if (error, "RequestConnection()"))
> >      return;
> >  
> >    /* FIXME: there should be convenience API for this */
> 
> Is this still applicable? Probably not, because real applications (except MC)
> shouldn't be using RequestConnection anyway.

True, lots of examples are/contains not really exemplary code. I reported bug
#51687 for that, let's consider it out of scope for this bug.

> @@ +212,5 @@
> >    if (die_if (error, "RequestConnection()"))
> >      return;
> >  
> >    /* FIXME: there should be convenience API for this */
> > +  factory = tp_simple_client_factory_new (NULL);
> 
> Isn't this leaked?

Good catch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.