[Bug 33410] Do on-disk avatar cache in CM

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33410

--- Comment #19 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-06-08 03:29:58 UTC ---
(In reply to comment #18)
> My idea was to define the set as "anyone for who the CM has a useful way to
> lookup on disk cache" which is for gabble the same as
> "/presence-received-avatars".

OK, you've convinced me that this is useful.

> With the exception in the case the client is doing persistent storage of
> contacts, like N9(00), then client could still call RequestAvatars on a
> first-seen contact (to get avatar of offline XMPP contacts but won't update
> until the contact is seen online).

This does lead to this weird situation:

* first contact with bob at example.com
  - address book explicitly requests avatar
  - Bob temporarily has an avatar token (URI)

* sign out and back in

* ask about Bob's avatar token
  - it's omitted from the reply, and presumably NULL in C code
    (we don't know that Bob doesn't have an avatar, which would be "",
    but neither do we know that he does, which would be a nonempty string)

Should the UI remember the old avatar URI for this situation (and use it as a
"best guess" at Bob's avatar until told otherwise), or should it copy the bytes
of the avatar into permanent storage like the N9 does, and display that copy?

I suppose either of those would be fine, really...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.