[Bug 33410] Do on-disk avatar cache in CM

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33410

--- Comment #20 from Xavier Claessens <xclaesse at gmail.com> 2012-06-08 03:36:35 UTC ---
(In reply to comment #19)
> (In reply to comment #18)
> > With the exception in the case the client is doing persistent storage of
> > contacts, like N9(00), then client could still call RequestAvatars on a
> > first-seen contact (to get avatar of offline XMPP contacts but won't update
> > until the contact is seen online).
> 
> This does lead to this weird situation:
> 
> * first contact with bob at example.com
>   - address book explicitly requests avatar
>   - Bob temporarily has an avatar token (URI)
> 
> * sign out and back in
> 
> * ask about Bob's avatar token
>   - it's omitted from the reply, and presumably NULL in C code
>     (we don't know that Bob doesn't have an avatar, which would be "",
>     but neither do we know that he does, which would be a nonempty string)
> 
> Should the UI remember the old avatar URI for this situation (and use it as a
> "best guess" at Bob's avatar until told otherwise), or should it copy the bytes
> of the avatar into permanent storage like the N9 does, and display that copy?
> 
> I suppose either of those would be fine, really...

I think this is client's choice. There are 3 possibilities:
1) stateless clients (empathy) will just not display avatar for those contacts
2) opportunistically statefull clients (tp-logger) will remember the cached URI
and fallback to no avatar if the CM decided to cleanup its cache.
3) statefull clients (N9) will copy the file into its own storage and will use
that until the CM gives a new URI.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.