[Bug 51077] New: Never returns from RequestContactInfo() if contact is offline

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51077

             Bug #: 51077
           Summary: Never returns from RequestContactInfo() if contact is
                    offline
    Classification: Unclassified
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: idle
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


If you call RequestContactInfo() for a nickname which isn't online, Idle will
never return an error (or indeed return at all).

You can see that this is the case by inspection of idle-contact-info.c:
tp_svc_connection_interface_contact_info_return_from_request_contact_info() is
only called from _return_from_request_contact_info() which is only called from
_end_of_whois_handler().

Idle will receive an ERR_NOSUCKNICK for the nickname:

  401 <nickname> :some human-readable message

I guess it's not possible to match it up to the WHOIS, but if we get one of
these while a WHOIS is pending it seems reasonable to assume the user is not
online and return an error. (Empathy doesn't actually show you that an error
occurred, but at least the “Information requested” spinner disappears.”)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.