[Bug 51078] New: Doesn't return an error from RequestContactInfo when fetching a vCard fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51078

             Bug #: 51078
           Summary: Doesn't return an error from RequestContactInfo when
                    fetching a vCard fails
    Classification: Unclassified
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: gabble
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


When I type "/whois idontexist at collabora.co.uk" into Empathy, here's what
happens on the wire:

<!-- sent -->
<iq id="559270952839" to="idontexist at collabora.co.uk" type="get"
xmlns="jabber:client">
    <vCard xmlns="vcard-temp"/>
</iq>

<!-- received -->
<iq from="idontexist at collabora.co.uk" id="559270952839"
to="will.thompson at collabora.co.uk/Queeg" type="error" xmlns="jabber:client">
    <error type="cancel">
        <item-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
    </error>
</iq>

But dbus-monitor shows this:

method call sender=:1.146 -> dest=:1.137 serial=1744
path=/org/freedesktop/Telepathy/Connection/gabble/jabber/will_2ethompson_40collabora_2eco_2euk_2fQueeg;
interface=org.freedesktop.Telepathy.Connection.Interface.ContactInfo;
member=RequestContactInfo
   uint32 146
method return sender=:1.137 -> dest=:1.146 reply_serial=1744
   array [
   ]

So Gabble is returning success (with no info) rather than a failure. This is
irrespective of the error returned by the server. For instance, trying a
contact at a non-existent domain:

<!-- sent -->
<iq id="127336127425" to="lol at whut.example.com" type="get"
xmlns="jabber:client">
    <vCard xmlns="vcard-temp"/>
</iq>

<!-- received -->
<iq from="lol at whut.example.com" id="127336127425"
to="will.thompson at collabora.co.uk/Queeg" type="error" xmlns="jabber:client">
    <error type="cancel">
        <remote-server-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
        <text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Server-to-server
connection failed: DNS resolution failed</text>
    </error>
</iq>

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.