[Bug 45842] deprecate call_when_ready in master, delete it from 1.0

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45842

--- Comment #18 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-03-05 15:08:41 PST ---
Comment on attachment 58026
  --> https://bugs.freedesktop.org/attachment.cgi?id=58026
tp_list_connection_managers: use tp_proxy_prepare_async

Review of attachment 58026:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=45842&attachment=58026)
-----------------------------------------------------------------

::: telepathy-glib/connection-manager.c
@@ +1676,5 @@
>    size_t base_len;
>    gsize refcount;
>    gsize cms_to_ready;
>    unsigned getting_names:1;
> +  unsigned had_weak_object:1;

Are we really still using this instead of gboolean in new code?

@@ +1732,4 @@
>        g_ptr_array_add (list_context->arr, NULL);
>        cms = (TpConnectionManager **) list_context->arr->pdata;
>  
> +      if (!list_context->had_weak_object || list_context->weak_object != NULL)

I don't understand this. Call the callback if:

 * there was no weak object (regardless of whether it's been disposed already
or not)
 * OR, there is a weak object around right now

So the only case where the callback won't get called is if:

 * had_weak_object is TRUE
 * AND, the weak object is not around.

Okay so this now makes sense: it'll only call the callback if the weak object
is still around. Would it be possible to get a comment to explain this a bit
more though please?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.