[Bug 39189] [next] decide on a policy for transfer, naming and containers

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39189

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-03-05 12:09:49 PST ---
(In reply to comment #3)
> 1. What is our preferred transfer mode for single objects?
[...]
> Additionally, I think whenever we have a "dup" or "borrow" without a
> corresponding "get", in Telepathy 1.0 we should use "Rename to:" to rename it
> to get_foo for introspective bindings. (This is an introspection API break.)

Interesting, I didn't know about "Rename to:".

> My opinion: we should bite the bullet and make "get" mean (transfer full). We
> can have parallel "borrow" functions as "C bindings" where it makes sense, and
> use (skip) to omit them from introspection.

Agreed.

> 2. What is our preferred transfer mode for plural objects?
[...]
> Current practice in tp-glib: "get" means (transfer container), e.g. in
> TpAccount. This may have been Jonny's idea, or he might have just copied
> current practice from Empathy.

Good question, I can't remember how things went down any more.

> My opinion: I think we should make "get" mean (transfer full), and have
> parallel "borrow" functions if we really need them.

Agreed. I also think GIO is a better library to copy than Gtk.

> 3. What is our preferred container for plural getters?
[...]
> My opinion: let's standardize on GList for least-astonishment.

Agreed again. GPtrArray is a hassle and everyone knows exactly how linked lists
work...hopefully. It's a shame we don't have a type-safe container we can use.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.