[Bug 57739] New: AccountsModel does not list Salut contacts on load

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=57739

          Priority: medium
            Bug ID: 57739
          Assignee: telepathy-bugs at lists.freedesktop.org
           Summary: AccountsModel does not list Salut contacts on load
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: sander at outrightsolutions.nl
          Hardware: All
            Status: NEW
           Version: git master
         Component: tp-qt
           Product: Telepathy

Created attachment 70836
  --> https://bugs.freedesktop.org/attachment.cgi?id=70836&action=edit
use ContactManager features instead of Connection features for
FeatureRosterGroups check

With a local-xmpp account and using telepathy-qt + ktp-contactlist, when going
from offline to available, no contacts on the network will be found. Only
contacts that come online later will be added to the contact list.

The original bug can be found here :
https://bugs.kde.org/show_bug.cgi?id=301786

I've done some experimenting with local xmpp and also a jabber account to
verify behaviour. It looks like the contact list groups are wrongfully assumed
for local-xmpp because the features of the Connection are checked. The
requestedFeatures on the connection contains a Connection::FeatureRosterGroups
feature, leading to a situation where setStateSuccess() is never called,
because in introspectGroups() the missing functionality is caught and
short-circuited. 

My guess is it should instead check on the supported features of the
ContactManager, not on the requested features of the Connection. I've created a
patch, which makes local-xmpp behave as expected.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.