[Bug 55391] stop MC using things deprecated in 0.20

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55391

--- Comment #28 from Xavier Claessens <xclaesse at gmail.com> ---
Comment on attachment 67790
  --> https://bugs.freedesktop.org/attachment.cgi?id=67790
Generally use GVariant, not GHashTable, for channels'  properties

Review of attachment 67790:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=55391&attachment=67790)
-----------------------------------------------------------------

I'm not sure I like the double conversion gvalue->gvariant->gvalue, it adds
extra source of potential bugs and wast of memory/cpu. I'm wondering if this
isn't premature for C code. But we are not writing a kernel so I guess perf
issue is irrelevant.

::: src/mcd-client.c
@@ +1570,5 @@
> +    /* FIXME: when Xavier's tp_vardict_get_*() functions have landed,
> +     * make _mcd_client_match_property use those on variant_properties
> +     * rather than doing this. But for now... */
> +    dbus_g_value_parse_g_variant (channel_properties, &value);
> +    g_assert (G_VALUE_HOLDS (&value, TP_HASH_TYPE_STRING_VARIANT_MAP));

They landed now

-- 
You are receiving this mail because:
You are the QA Contact for the bug.