[Bug 55391] stop MC using things deprecated in 0.20

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55391

--- Comment #29 from Xavier Claessens <xclaesse at gmail.com> ---
Comment on attachment 67794
  --> https://bugs.freedesktop.org/attachment.cgi?id=67794
McpDispatchOperation: use a new factory for each  connection

Review of attachment 67794:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=55391&attachment=67794)
-----------------------------------------------------------------

::: mission-control-plugins/dispatch-operation.c
@@ +425,5 @@
>  
>            if (ret_ref_channel != NULL)
>              {
> +              /* FIXME: in next, this method should take a TpClientFactory
> +               * argument, and pass it on here */

I'm not sure to understand why plugins needs to subclass McpDispatchOperation,
but I think in next, we should have a mandatory construct-only "factory"
property and mcp_dispatch_operation_ref_connection() can then use
self->priv->factory. The McpDispatchOperation objects are created from plugins
so we cannot guarantee that we got a factory?

Won't it be easier to already create a new factory in constructed(), and maybe
somehow share it wit the rest of MC, and use that in
mcp_dispatch_operation_ref_connection() so at least all TpConnections comes
from the same factory?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.