[Bug 39189] [next] decide on a policy for transfer, naming and containers

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39189

--- Comment #12 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-09-03 11:07:48 UTC ---
(In reply to comment #11)
> I think we'll decide that we won't decide...

No, I do not want _get_ to mean different things in different modules. It's bad
enough that telepathy-glib is inconsistent with GIO and GLib is inconsistent
with itself.

> IMO the container isn't really important, we can live we inconsistencies

That's reasonable.

> What I'm more concerned about is the get VS dup. I think getters generally does
> not ref/copy the return value if it is in the internal format.

They usually do in GIO, and they have to if you ever want to be thread-safe.

> In the end, I think the most important is to avoid subtle changes in our
> high-level API. Changing a _get_ to suddenly return a ref is going to be make
> app porting much more complex.

This is a good argument in favour of what I called the Guillaume/Xavier
proposal in Comment #10.

(In reply to comment #5)
> And to finish, if we go with GList, please make it (transfer full/none), but
> (transfer container) is just confusing IMO.

Let's supersede our existing GList (transfer container) APIs with a "dup"
version (dup_valid_accounts() etc.)? I think there are only a couple.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.