[Bug 39189] [next] decide on a policy for transfer, naming and containers

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Sep 3 13:10:39 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=39189

--- Comment #13 from Xavier Claessens <xclaesse at gmail.com> 2012-09-03 11:10:39 UTC ---
So from a pragmatic POV:

 - We have 867 _get_. AFAIK they are all[1] returning the internal
pointer/value. That's too much to change.

 - We have 9 _borrow_. That's small enough to consider renaming them to _get_.

 - We have 34 _dup_. I would consider that too much to change.

[1] With the exception of some transfer-container:
 * If the structure is a GPtrArray (or anything that knows how to free its
elements) I would consider them as dup (AFAIK that's already the case, see
tp_connection_dup_contact_list).

 * GList is really the special case here. They are often _get_ (e.g.
tp_account_manager_get_valid_accounts). 1) I surely do NOT want to change them
to not dup the glist anymore, that would make crashes in apps badly ported. 2)
I would be in favor of making them transfer full and rename to _dup_. 3) I'm ok
with just living with that and not change them at all.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list