[Bug 54270] Don't run the TplLogEventFilter from a separate thread

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 4 18:30:40 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=54270

Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://cgit.freedesktop.org |http://cgit.collabora.com/g
                   |/~debarshir/telepathy-logge |it/user/nicolas/telepathy-l
                   |r/log/?h=event-filter       |ogger.git/log/?h=event-filt
                   |                            |er

--- Comment #2 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2012-09-04 16:30:40 UTC ---
I have simplified your branch a bit. I removed the callback indirection, by
setting the real callback/user_data in the GSimpleAsyncResult. I also fixed
events leak in an unlikely case that get_events_finish() is not called and used
complete_in_idle() instead of g_idle_add().

http://cgit.collabora.com/git/user/nicolas/telepathy-logger.git/log/?h=event-filter

The remaining issue is the lock in get_events_async(). Calling this method a
second time before the previous call has finish has undefined result according
to mutex documentation.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list