[Bug 54879] [next] initial 'next' branch

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54879

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-09-13 16:18:05 UTC ---
In "replace tp_{connection,account,channel}_new calls with ensure factory
calls"

+  g_object_get (self,
+      "factory", &factory,
+      NULL);

Ugh. If the assumption is that every McpDispatchOperation has a "factory"
property, I think it'd be better to give it a dup_factory() method or make the
property part of the GInterface.

However, I think it'd be better still if we made the factory an explicit
parameter to the function. We're going to be breaking the plugin API/ABI
anyway, because it depends on telepathy-glib which is breaking API/ABI. I think
plugins can be expected to supply their own factory - they might well have a
different set of desirable features, or even a different desired subclass.

[src/mcd-account-manager.c]
+    factory = tp_automatic_client_factory_new (priv->dbus_daemon);

The AM should have one TpAutomaticClientFactory - or, preferably,
TpSimpleClientFactory - and cache it. Otherwise, there's no point in using a
factory, since objects aren't going to be unique.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.