[Bug 54879] [next] initial 'next' branch

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54879

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-09-13 16:30:48 UTC ---
In "replace now sealed struct member accessing with getters"

I think this could usefully be done on master. I'll prepare a patch based on
yours (I was actually about to do part of it for other reasons anyway).

> +    params = tp_protocol_borrow_params (protocol);

This function broke ABI between master and next, and I think Xavier might be
removing it altogether now. I think I'm going to just use dup_params() so the
same code works in both - efficiency is not exactly MC's strong point anyway.

> mcd_account_check_parameters

This still frees protocol with the TpConnectionManagerProtocol free-function.
That's not going to work. I see you fixed it in the next patch, though.

> check_one_parameter_update (McdAccount *account,
>                             TpConnectionManagerProtocol *protocol,

Similar. Again, the next patch fixes it.

> +    if (!tp_conn || tp_proxy_get_invalidated (TP_PROXY (tp_conn)) != NULL) return;

I'm not going to incorporate this patch without chopping off the "return" onto
its own line :-)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.