[Bug 58198] Move Jingle code to Wocky

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=58198

--- Comment #1 from Jonny Lamb <jonny.lamb at collabora.co.uk> ---
This was actually a lot smaller than I was expecting.

The gabble branch is obviously fine. I seriously lolled at your perl script
though. u r such a l33t haxxor despite what you try to tell us all.

Yeah should the quirks really be in the public API? (yes I realise talking
about public API with Wocky is a bit of a joke) They could at least be more
internal, no?

I didn't check all the new jingle docstrings word for word; I reckon they'll be
fine.

I see you've moved this stuff into wocky/jingle-*.[ch]. Although I hate the
"wocky-" prefix as much as anyone else, I think inconsistency is even worse.
What are your thoughts on this? Perhaps it's less of a problem given we have a
big wocky.h now? Speaking of which...

The new headers don't have the WOCKY_H_INSIDE check.

I did a git grep -i gabble in your wocky tree and there are loads of references
that probably shouldn't be around anymore, like header guards, comments listing
the filename as gabble-jingle-session.c and stuff like that. It would be nicer
to have less of this.

Otherwise hot. I wonder if we could feasibly have roughly the same test
coverage of the Jingle code directly in Wocky one day? Sounds pretty tricky to
me tbh.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.